Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subject Transform Stream Configuration Part 1 #978

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Subject Transform Stream Configuration Part 1 #978

merged 2 commits into from
Sep 21, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Sep 20, 2023 •
edited
Loading

Add subject_transform to stream configuration. (Part 1.)
TBD Part 2/3/4 add subject_transform to mirror, source and republish

@scottf scottf mentioned this pull request Sep 20, 2023
Open
15 tasks
jnmoyne
jnmoyne approved these changes Sep 20, 2023
View reviewed changes
Copy link

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also implement the test for it in StreamInfoTests but otherwise LGTM

@scottf scottf changed the title Subject Transform Stream Configuration Subject Transform Stream Configuration Part 1 Sep 21, 2023
@scottf scottf merged commit d28d9c9 into main Sep 21, 2023
1 check passed
@scottf scottf deleted the subject-transform branch September 21, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnmoyne jnmoyne jnmoyne approved these changes

@Jarema Jarema Awaiting requested review from Jarema

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @jnmoyne